Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

R4R: Register x/gov Message Types on init #3446

Merged
merged 2 commits into from
Jan 30, 2019
Merged

R4R: Register x/gov Message Types on init #3446

merged 2 commits into from
Jan 30, 2019

Conversation

alexanderbez
Copy link
Contributor

@alexanderbez alexanderbez commented Jan 30, 2019 •
edited
Loading

Register x/gov message types on init. This will ensure message signature bytes have the canonical type and value fields.

closes: #3443

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added entries in PENDING.md with issue #

  • rereviewed Files changed in the github PR explorer

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@alexanderbez alexanderbez changed the title WIP: Register x/gov Message Types on init R4R: Register x/gov Message Types on init Jan 30, 2019
@codecov
Copy link

codecov bot commented Jan 30, 2019 •
edited
Loading

Codecov Report

Merging #3446 into develop will increase coverage by 0.05%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##           develop    #3446      +/-   ##
===========================================
+ Coverage    59.41%   59.47%   +0.05%     
===========================================
  Files          135      135              
  Lines         9979     9981       +2     
===========================================
+ Hits          5929     5936       +7     
+ Misses        3678     3673       -5     
  Partials       372      372

jackzampolin
jackzampolin approved these changes Jan 30, 2019
View reviewed changes
Copy link
Member

@jackzampolin jackzampolin left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch @faboweb and nice fix w/ tests @alexanderbez LGTM 👍

cwgoes
cwgoes approved these changes Jan 30, 2019
View reviewed changes
Copy link
Contributor

@cwgoes cwgoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@cwgoes cwgoes merged commit fd71351 into develop Jan 30, 2019
@cwgoes cwgoes deleted the bez/3443-fix-gov-sign-bytes branch January 30, 2019 18:22
@jackzampolin jackzampolin mentioned this pull request Jan 30, 2019
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cwgoes cwgoes cwgoes approved these changes

@jackzampolin jackzampolin jackzampolin approved these changes

@alessio alessio Awaiting requested review from alessio

@sunnya97 sunnya97 Awaiting requested review from sunnya97

@faboweb faboweb Awaiting requested review from faboweb

@ebuchman ebuchman Awaiting requested review from ebuchman

@rigelrozanski rigelrozanski Awaiting requested review from rigelrozanski

Assignees
No one assigned
Labels
C:x/gov
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SignBytes serialization for all governance transaction wasn't standardized
3 participants
@alexanderbez @jackzampolin @cwgoes